Skip to content

feat: Add tokens full page #21628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Add tokens full page #21628

wants to merge 8 commits into from
+1,317 −878

Conversation

@brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 24, 2025 •
edited by cursor bot
Loading

Description

This PR adds the Tokens Full page to the wallet

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/c/projects/DSYS/boards/1888?selectedIssue=DSYS-245

Manual testing steps

Feature: Tokens Full Page

  Scenario: user: null
    Given: null

    When user uncomments line 265 in `app/components/UI/Tokens/index.tsx` and clicks on View all Tokens
    Then it should lead them to the Tokens Full View page with a full view of tokens with preexisting behaviors still intact

Screenshots/Recordings

Before

After

Tokens Full View

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-10-24.at.09.18.25.mp4

Tokens Tab still functional

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-10-24.at.09.19.46.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Introduces a full-screen Tokens view with navigation from a new "View all tokens" action, refactors Tokens tab, enhances TokenList (props, limits, styling), and updates related headers, routes, and tests.

  • Navigation/Routes:
    • Add Routes.WALLET.TOKENS_FULL_VIEW and register TokensFullView in MainNavigator (header hidden).
    • Expose AddAsset in main stack (header hidden).
  • Tokens UI:
    • New TokensFullView screen with header (BottomSheetHeader), progressive loading, control bar, and actions (add/remove/refresh tokens).
    • Extract TokensTabView from legacy Tokens and wire it in Wallet tabs.
    • TokenList improvements:
      • New props: flashListProps, maxItems; computes displayTokenKeys and renders "wallet.view_all_tokens" button that navigates to TOKENS_FULL_VIEW.
      • Types moved to TokenList.types and barrel export added.
      • Remove TokenListFooter and its tests.
    • TokenListControlBar/BaseControlBar: accept optional style and pass-through.
  • Other UI tweaks:
    • Replace nav bar in AddAsset with BottomSheetHeader back handling.
    • Minor bottom sheet wrapper adjustments in token sort/filter.
  • i18n: Add wallet.view_all_tokens string.
  • Tests:
    • Add tests for TokensFullView and TokenList (incl. view-all behavior) and update TokensTabView tests.
    • Update MainNavigator snapshot; remove TokenListFooter tests.

Written by Cursor Bugbot for commit 9701ea9. This will update automatically on new commits. Configure here.

@brianacnguyen brianacnguyen requested a review from a team as a code owner October 24, 2025 16:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Oct 24, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@brianacnguyen brianacnguyen self-assigned this Oct 24, 2025
@brianacnguyen brianacnguyen added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Oct 24, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions github-actions bot added size-M and removed size-L labels Oct 24, 2025
brianacnguyen
brianacnguyen commented Oct 24, 2025
View reviewed changes
app/components/Views/AddAsset/AddAsset.tsx
}, [updateNavBar]);
const handleBackPress = useCallback(() => {
navigation.goBack();
}, [navigation]);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Import assets page was moved to the main stack to work with both the Tokens tab and tokens full page, so the header needs to be refactored to go inside the page

georgewrmarshall
georgewrmarshall reviewed Oct 24, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall left review comments

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@brianacnguyen brianacnguyen

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-M team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brianacnguyen @georgewrmarshall @metamaskbot